Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reapply reverted PR enabling view export #13677

Merged
merged 21 commits into from
Jan 24, 2025
Merged

Reapply reverted PR enabling view export #13677

merged 21 commits into from
Jan 24, 2025

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Jan 21, 2025 •
edited
Loading

Reapply "Export views" (#13509) (the original PR enabling export views was reverted due to a failed build) with some additions:

  • Export view metadata dummy
  • Review fixes requested here
  • Refactoring in export pipeline to stop allocating tx ids when it is not necessary
  • Export tests with reboots + fixes (mainly for cancelled and cancellation state of the export)
  • Feature flag to not include views in the exports. (It is needed to be able to rollback the database.)
  • Minor fixes

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Feature epic:

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@jepett0 jepett0 marked this pull request as ready for review January 22, 2025 10:22
@jepett0 jepett0 requested a review from a team as a code owner January 22, 2025 10:22
@jepett0 jepett0 requested a review from CyberROFL January 22, 2025 10:22
CyberROFL
CyberROFL reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом хорошо, есть небольшие замечания.

ydb/core/tx/schemeshard/schemeshard_export__create.cpp Outdated Show resolved Hide resolved
ydb/core/tx/schemeshard/schemeshard_export__create.cpp Outdated Show resolved Hide resolved
ydb/core/tx/schemeshard/schemeshard_export_scheme_uploader.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@jepett0 jepett0 mentioned this pull request Jan 23, 2025
Merged
@jepett0 jepett0 requested a review from CyberROFL January 23, 2025 11:48
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@jepett0
Copy link
Collaborator Author

jepett0 commented Jan 24, 2025

Сделал rebase на свежий main на всякий случай. Разница - последние 2 коммита:

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

⚪ 2025-01-24 13:26:56 UTC Pre-commit check linux-x86_64-release-asan for 4b53f94 has started.
⚪ 2025-01-24 13:27:08 UTC Artifacts will be uploaded here
⚪ 2025-01-24 13:30:29 UTC ya make is running...
🟡 2025-01-24 15:02:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13200 13110 0 44 14 32

⚪ 2025-01-24 15:03:55 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-24 15:18:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
148 (only retried tests) 102 0 15 2 29

⚪ 2025-01-24 15:18:35 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-24 15:36:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
85 (only retried tests) 40 0 14 2 29

🟢 2025-01-24 15:36:44 UTC Build successful.
🔴 2025-01-24 15:37:14 UTC ydbd size 3.6 GiB changed* by +2.9 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 552d995 merge: 4b53f94 diff diff %
ydbd size 3 860 142 800 Bytes 3 863 145 176 Bytes +2.9 MiB +0.078%
ydbd stripped size 1 350 121 488 Bytes 1 351 220 848 Bytes +1.0 MiB +0.081%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

⚪ 2025-01-24 13:29:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4b53f94 has started.
⚪ 2025-01-24 13:29:38 UTC Artifacts will be uploaded here
⚪ 2025-01-24 13:32:59 UTC ya make is running...
🟡 2025-01-24 14:54:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27594 25057 0 8 2406 123

⚪ 2025-01-24 14:57:34 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-24 15:08:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
197 (only retried tests) 77 0 2 0 118

⚪ 2025-01-24 15:08:52 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-24 15:18:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
177 (only retried tests) 60 0 0 0 117

🟢 2025-01-24 15:18:43 UTC Build successful.
🟡 2025-01-24 15:19:08 UTC ydbd size 2.1 GiB changed* by +1.6 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 552d995 merge: 4b53f94 diff diff %
ydbd size 2 221 461 136 Bytes 2 223 184 304 Bytes +1.6 MiB +0.078%
ydbd stripped size 469 840 656 Bytes 470 129 040 Bytes +281.6 KiB +0.061%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@jepett0 jepett0 requested a review from pixcc January 24, 2025 13:59
@jepett0 jepett0 merged commit 1d3289e into ydb-platform:main Jan 24, 2025
15 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request Jan 27, 2025
Merged
This was referenced Jan 28, 2025
Closed
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixcc pixcc pixcc approved these changes

@pnv1 pnv1 pnv1 approved these changes

@CyberROFL CyberROFL Awaiting requested review from CyberROFL

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jepett0 @CyberROFL @pnv1 @pixcc